-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update snapcraft.yaml files for arm binaries #45
Conversation
It looks like the failure of CI is from unrelated changes upstream in Snapcraft: see canonical/snapcraft#2883 As we're building our own Docker images then the changes will need to be massaged into our Dockerfiles to add |
CI fixed. (Sorry it took me so long to circle back and resync against main) |
cc: @TravisEz13 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to test this, but we don't currently have ARM. Do you know a public CI system that can run ARM?
unfortunately I don't know about any available CI systems that have an ARM runner. I've been on the lookout for other snap projects, too.. |
Add arm32 and arm64 binaries if the build is executed on an appropriate host Signed-off-by: Daniel Llewellyn <daniel@bowlhat.net>
480f4a6
to
53b75e8
Compare
* Be explicit about supported platforms. Fail if the platform is unsupported. Signed-off-by: Dani Llewellyn <diddledani@ubuntu.com>
Use `rm -f` for `libcrypto.so.1.0.0` and `libssl.so.1.0.0` to cope with any cases where these aren't present. My local build fails here without this change Signed-off-by: Dani Llewellyn <diddledani@ubuntu.com>
Thanks for the updates. |
I don't have a build environment for this, but I have been promised one "soon". |
Add arm32 and arm64 binaries of PowerShell if the build is executed on an appropriate host.
To build an arm32 or arm64 version of the snap it will be necessary to modify the build-bots to execute the job on arm32 and arm64 hosts in addition to the current amd64. I believe it will also require additional
Dockerfile
definitions (at./tools/releaseBuild/Images
) to create an appropriatesnapcraft
container for each new architecture.Fixes #55
Fixes #73
Signed-off-by: Daniel Llewellyn daniel@bowlhat.net